TrafficSignalCondition and TrafficSignalControllerCondition not aligned, typo in TrafficSignalController
In #437 (closed) the descriptions of attributes of multiple classes regarding Traffic Signals have been changed. However, the classes "TrafficSignalCondition" and "TrafficSignalControllerCondition" have not been changed accordingly. Furthermore, there is a typo in the TrafficSignalController class "ID of the TrafficSignalController"
Document version of this comment
Branch: v1.3.0-RC1
Description:
- TrafficSignalCondition still suggests that signals must be listed in OpenSCENARIO under RoadNetwork to be accessible, although this has been changed in the TrafficSignalState class. Furhtermore, the main description contains unnecessary information.
- TrafficSignalControllerCondition descriptions are not aligned with updated descriptions of TrafficSignalController.
- TrafficSignalController class contains a typo (missing c) "ID of the TrafficSignalController"
- Phase class contains a typo (superfluous "e" after traffic) in "trafficeSignalGroupState"
Suggestion:
Class TrafficSignalCondition
Annotation:
Considered true if a referenced traffic signal (e.g. from an OpenDRIVE file) reaches a specific observable state. Signal IDs are listed in the TrafficSignal list of the RoadNetwork together with their states and their controllers to enable dynamic signal modelling.
Attributes:
Name | Type | Cardinality | AppliedStereotypes | Annotation |
---|---|---|---|---|
name | string | 1...1 | < XSDattribute > | ID of the referenced signal in a road network file. |
state | string | 1...1 | < XSDattribute > | Observable state of the signal to be reached for the condition to become true. |
Class TrafficSignalControllerCondition
Annotation:
Considered true if a given traffic signal controllerTrafficSignalController (which shallmay be defined within OpenSCENARIO or externally) reaches a specific semantic phase state.
Attributes:
Name | Type | Cardinality | AppliedStereotypes | Annotation |
---|---|---|---|---|
phase | string | 1...1 | < XSDattribute > | Name of the referenced phase of the TrafficSignalController |
trafficSignalControllerRef | TrafficSignalController | 1...1 | nameRef, XSDattribute | Name of the referenced TrafficSignalController. |
phaseRef | Phase | 0..* | transient | The reference to the semantic phase (phase is the referential key in the referenced TrafficSignalController). |
Class TrafficSignalController
Attributes:
Name | Type | Cardinality | AppliedStereotypes | Annotation |
---|---|---|---|---|
name | string | 1...1 | < XSDattribute > | ID of the TrafficSignalController for reference within the scenario and the reference to an OpenDRIVE signal group ID. |
Class Phase
Attributes:
Name | Type | Cardinality | AppliedStereotypes | Annotation |
---|---|---|---|---|
traffic |
TrafficSignalGroupState | 0...1 | < XSDelement > | Each phase can have one TrafficSignalGroupState to provide the observable state for all traffic signals that are controlled by the controller if they share the same state. E.g. name="go" ("off;off;on"). |
Migration Path
The attribute trafficeSignalGroupState
in class Phase must be replaced with the correct spelling trafficSignalGroupState
.